[bisq-network/bisq] [WIP] Add mediator support (#3169)

[sqrrm]

sqrrm commented on this pull request.

Some minor comments

> +            log.warn("bannedDisputeResolvers=" + bannedDisputeResolvers);
+        Set<T> disputeResolverSet = getCollect(bannedDisputeResolvers);
+
+        Map<NodeAddress, T> map = new HashMap<>();
+        for (T disputeResolver : disputeResolverSet) {
+            NodeAddress disputeResolverNodeAddress = disputeResolver.getNodeAddress();
+            if (!map.containsKey(disputeResolverNodeAddress))
+                map.put(disputeResolverNodeAddress, disputeResolver);
+            else
+                log.warn("disputeResolverAddress already exist in disputeResolver map. Seems an disputeResolver object is already registered with the same address.");
+        }
+        return map;
+    }
+
+    @NotNull
+    protected abstract Set<T> getCollect(List<String> bannedDisputeResolvers);

`getCollect()` is not a great name, `getSet()` might be better

> +        registerButton.disableProperty().bind(model.registrationEditDisabled);
+        registerButton.setOnAction(e -> onRegister());
+
+        Button revokeButton = buttonButtonTuple2.second;
+        revokeButton.setDefaultButton(false);
+        revokeButton.disableProperty().bind(model.revokeButtonDisabled);
+        revokeButton.setOnAction(e -> onRevoke());
+
+        final TitledGroupBg titledGroupBg = addTitledGroupBg(gridPane, ++gridRow, 2,
+                Res.get("shared.information"), Layout.GROUP_DISTANCE);
+
+        titledGroupBg.getStyleClass().add("last");
+
+        Label infoLabel = addMultilineLabel(gridPane, gridRow);
+        GridPane.setMargin(infoLabel, new Insets(Layout.TWICE_FIRST_ROW_AND_GROUP_DISTANCE, 0, 0, 0));
+        infoLabel.setText(Res.get("account.arbitratorRegistration.info.msg"));

This info text is not generic enough for both mediator and arbitrator

>      }
 
 
     ///////////////////////////////////////////////////////////////////////////////////////////
     // Abstract methods
     ///////////////////////////////////////////////////////////////////////////////////////////
 
+    protected abstract List<String> getPubLeyList();

Should be getPub**K**eyList

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3169#pullrequestreview-282305011
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190831/5064c9ca/attachment.html>