[bisq-network/bisq] Add Makefile for automating localnet setup (#3718)

Chris Beams notifications at github.com
Mon Dec 2 16:37:01 UTC 2019


> `make clean && make build` should rebuild. I think Justin had comments on this too?

Yes. Changes are incoming that address this.

> Having a way to reset the node state, but keep the build state, seems like a nice-to-have. Rebuilding everything to reset a test from scratch isn't very efficient.

Agreed. You may have sync'd an earlier rev of the makefile, but now you'll see that in addition to the global `clean` that blows away both node and build state, there are also `clean-localnet` and `clean-build` that do the same for each.

> Ctrl+C inside screen tab closes it. There are quite a few test cases where you just need to take down a node temporarily or restart it.

Right, glad you caught this. I have `zombie` configured in my .screenrc such that when the process in a given window is killed, the window does not close, but is preserved in a "zombie" state such that `^[` kills it fully or pressing `@` resurrects it, in this case by re-running the original command, e.g. `make alice`, `make bitcoind` or whatever. This arrangement has been productive enough for me to roll with, but I forgot that this `zombie` configuration is not a default in screen. Here it is if you're interested:

    zombie "^["

More to the point, though, I'm working on improvements to the way screen is invoked by make that will naturally preserve the window when its process dies, allowing the user to get back to the natural `ctrl+c -> up arrow -> enter` workflow you mentioned and that we all likely want.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3718#issuecomment-560475118
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191202/c8ee0b47/attachment-0001.html>


More information about the bisq-github mailing list