[bisq-network/bisq] Revolut account should be a phone number (#3728)

Julian Knutsen notifications at github.com
Tue Dec 3 00:35:45 UTC 2019


Thanks for filing this. Some info from #general for the dev who picks this up:

I did a quick audit and it looks like when creating a Revolut account, the form says phone #, but the input is not validated so it could be a phone or email. The "Trade information" screen also has logic to show email or phone number depending on how it interprets the field. Not straight forward... Relevant comment in code:
```
    private static String getTitle(String accountId) {
        // From 0.9.4 on we only allow phone nr. as with emails we got too many disputes as users used an email which was
        // not registered at Revolut. It seems that phone numbers need to be registered at least we have no reports from
        // arbitrators with such cases. Thought email is still supported for backward compatibility.
        // We might still get emails from users who have registered when email was supported
        return accountId.contains("@") ? Res.get("payment.revolut.email") : Res.get("payment.revolut.phoneNr");
    }
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/3728#issuecomment-560944187
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191202/d0f4108a/attachment.html>


More information about the bisq-github mailing list