[bisq-network/bisq-website] Add Schema.org JSON-LD Microdata for SEO (Homepage) (#290)

Steve Jain notifications at github.com
Tue Dec 3 07:50:25 UTC 2019


m52go commented on this pull request.

@RiccardoMasutti some final feedback. Mostly little things, along with a couple of questions that could use your advice/guidance.

> @@ -63,6 +63,54 @@
         <script defer src="/js/bootstrap.min.js"></script>
         <script defer src="/js/scripts.js"></script>
 
+        <!-- Schema.org JSON-LD Markup for Search Engine Optimization -->
+        <script type='application/ld+json'>
+        {
+            "@context": "https://schema.org/",
+            "@type": "SoftwareApplication",
+            "applicationCategory": "FinanceApplication",
+            "name": "Bisq",

```suggestion
            "name": "Bisq Network",
```

Full name...also better differentiates from new `author` name "Bisq" (see below).

> @@ -63,6 +63,54 @@
         <script defer src="/js/bootstrap.min.js"></script>
         <script defer src="/js/scripts.js"></script>
 
+        <!-- Schema.org JSON-LD Markup for Search Engine Optimization -->
+        <script type='application/ld+json'>
+        {
+            "@context": "https://schema.org/",
+            "@type": "SoftwareApplication",
+            "applicationCategory": "FinanceApplication",
+            "name": "Bisq",
+            "image": "https://bisq.network/images/bisq-logo.svg",
+            "availableOnDevice": "Desktop",
+            "author": {
+            "@type": "Project",
+            "url": "https://bisq.network/dao/",

```suggestion
            "url": "https://bisq.network/",
```

See reasoning in comment below about referring to the author as Bisq instead of the Bisq DAO.

> @@ -63,6 +63,54 @@
         <script defer src="/js/bootstrap.min.js"></script>
         <script defer src="/js/scripts.js"></script>
 
+        <!-- Schema.org JSON-LD Markup for Search Engine Optimization -->
+        <script type='application/ld+json'>
+        {
+            "@context": "https://schema.org/",
+            "@type": "SoftwareApplication",
+            "applicationCategory": "FinanceApplication",
+            "name": "Bisq",
+            "image": "https://bisq.network/images/bisq-logo.svg",
+            "availableOnDevice": "Desktop",
+            "author": {
+            "@type": "Project",
+            "url": "https://bisq.network/dao/",
+            "name": "Bisq Decentralized Autonomous Organization",

```suggestion
            "name": "Bisq",
```

You're technically correct about Bisq being a DAO, but we usually refer to the body of the project as "Bisq" instead of the "Bisq DAO". Best practical example: see copyright on website footer...it's just plain old "Bisq" :)

> @@ -63,6 +63,54 @@
         <script defer src="/js/bootstrap.min.js"></script>
         <script defer src="/js/scripts.js"></script>
 
+        <!-- Schema.org JSON-LD Markup for Search Engine Optimization -->
+        <script type='application/ld+json'>
+        {
+            "@context": "https://schema.org/",
+            "@type": "SoftwareApplication",
+            "applicationCategory": "FinanceApplication",
+            "name": "Bisq",
+            "image": "https://bisq.network/images/bisq-logo.svg",
+            "availableOnDevice": "Desktop",
+            "author": {
+            "@type": "Project",
+            "url": "https://bisq.network/dao/",
+            "name": "Bisq Decentralized Autonomous Organization",
+            "sameAs": [

Are you sure this `sameAs` block is best placed in the `author` block? Might it be better to put it in the top-level block?

> +                "https://bisq.network/slack-invite",
+                "https://bisq.community/",
+                "https://lists.bisq.network/listinfo/bisq-contrib",
+                "https://webchat.freenode.net/?channels=bisq",
+                "https://www.reddit.com/r/bisq",
+                "https://keybase.io/team/bisq"
+	          ]
+            },
+            "downloadUrl": "https://bisq.network/downloads/",
+            "fileSize": "180MB",
+            "operatingSystem": [
+                "Windows",
+                "Linux",
+                "OSX"
+            ],
+            "releaseNotes": "https://github.com/bisq-network/bisq/releases",

```suggestion
            "releaseNotes": "https://github.com/bisq-network/bisq/releases/latest",
```

Nit: specifying the latest release is a more direct link to the most current release notes.

> +                "https://bisq.community/",
+                "https://lists.bisq.network/listinfo/bisq-contrib",
+                "https://webchat.freenode.net/?channels=bisq",
+                "https://www.reddit.com/r/bisq",
+                "https://keybase.io/team/bisq"
+	          ]
+            },
+            "downloadUrl": "https://bisq.network/downloads/",
+            "fileSize": "180MB",
+            "operatingSystem": [
+                "Windows",
+                "Linux",
+                "OSX"
+            ],
+            "releaseNotes": "https://github.com/bisq-network/bisq/releases",
+            "screenshot": "https://bisq.network/images/bisq_screen0.svg",

```suggestion
            "screenshot": "https://bisq.network/images/bisq_screen0.png",
```

This [changed](https://github.com/bisq-network/bisq-website/pull/304) since this PR was made.

> +	          ]
+            },
+            "downloadUrl": "https://bisq.network/downloads/",
+            "fileSize": "180MB",
+            "operatingSystem": [
+                "Windows",
+                "Linux",
+                "OSX"
+            ],
+            "releaseNotes": "https://github.com/bisq-network/bisq/releases",
+            "screenshot": "https://bisq.network/images/bisq_screen0.svg",
+            "softwareVersion": "{{ site.client_version }}",
+            "aggregateRating": {
+            "@type": "AggregateRating",
+            "ratingValue": "5",
+            "ratingCount": "20"

```suggestion
            "ratingCount": "5"
```

Making `ratingCount` equal to 5 matches the five 5-star reviews here:
https://www.facebook.com/pg/BisqExchange/reviews/

This gives the numbers a solid basis in case Google ever decides to dispute these figures.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-website/pull/290#pullrequestreview-325942803
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191202/0157fe72/attachment.html>


More information about the bisq-github mailing list