[bisq-network/bisq] [1.2.4] Takers transactions are inconsistent with what is shown to them at take offer time (#3733)

[Devin Bileck]

#### Description

When Bob takes an offer from Alice, then his actual transactions are inconsistent with what is shown to him at take offer time.

#### Version

release/v1.2.4 (c2e8806d165ff3bcc20b65dbe27052be2d1fd9f4)

### Steps to reproduce

1. Alice creates an offer to buy BTC as maker
2. Bob takes the offer to sell BTC as taker, using BTC as trade fees

### Expected behaviour

The multisig deposit shown in Bob's transactions is based on the amount to sell + security deposit, and his taker/tx fees are trade + mining fees.

### Actual behaviour

The multisig deposit is greater than the amount to sell + security deposit, and the taker/tx fees are less than that was shown during take offer time.

### Screenshots

[1] Funds required shown to Bob prior to taking the offer.
Amount to sell + security deposit = 0.015 <-- This should be the multisig deposit
Trade fee + mining fees = 0.000164‬ <-- This should be the taker + tx fees
![image](https://user-images.githubusercontent.com/603793/70029856-db618f80-155c-11ea-994f-ac9f689a278d.png)

[2] After Bob takes the offer, these are his transactions.
Taker + tx fees = 0.000088 <-- This does not match Trade fee + mining fees above
Multisig deposit = 0.015076 <-- This does not match Amount to sell + security deposit above
![image](https://user-images.githubusercontent.com/603793/70029981-1499ff80-155d-11ea-8264-969b3ff5e03d.png)

[3] Observing the trade details.
Taker mining fee = 0.000078 <-- This does not match the mining fee shown above in [1] (0.000114)
![image](https://user-images.githubusercontent.com/603793/70030922-0fd64b00-155f-11ea-8dc1-82a9b284b2a4.png)

#### Device or machine

- Windows 10
- Regtest environment using bitcoind 0.18.1

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/3733
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191203/d94dd0fb/attachment.html>