[bisq-network/bisq] Fix memory leak caused by not cleaning up unused threads (#3734)

Julian Knutsen notifications at github.com
Tue Dec 3 17:42:33 UTC 2019


With all that said, I did audit the code and it seems like a low-risk change. It is only called in the connection shutdown path and follows the exact same pattern as the `singleThreadExecutor` object. If there was so bug there it would likely already be found with the existing `shutDown()` code.

If the retesting effort isn't too much it is probably worth including so it doesn't have to wait until the January release.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3734#issuecomment-561278121
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191203/14037fca/attachment.html>


More information about the bisq-github mailing list