[bisq-network/bisq] DAO > BSQ Wallet > Transactions table persists when clicking away from Transactions tab (#3739)

[Chris Beams]

### Description

There is a bug in the BSQ Wallet > Transactions tab that causes the transactions table to stay visible even when the user clicks away from the Transactions tab to the Send or Receive tab.

#### Version

v1.2.3, but has been seen in earlier versions as well.

### Steps to reproduce

>From a conversation with @KanoczTomas and @chimp1984 in the #standup Keybase channel:

@cbeams wrote:

> It's reproducible for me but only with a freshly restarted Bisq node in the mix. This is against the v1.2.3 release:
> 1. Shut down Bisq if it is already running and open it afresh.
> 2. Go to DAO > BSQ Wallet
> 3. Notice that the selected tab on the left is "SEND"; notice that there are two major sections on the right: "My wallet balance" and "Send funds"
> 4. Click on the "TRANSACTIONS" tab on the left
> 5. Notice that the table of your BSQ transactions now takes up the lower-right section of the screen, where "Send funds" was under the SEND tab.
> 6. Now click oncce again on the SEND tab. Notice that the table of transactions persists, occluding the expected "Send funds" section. This is the bug.
> 7. Click on Account to leave the DAO section.
> 8. Repeat steps 2-5 above.
> 9. Attempt to repeat step 6, but notice that you cannot reproduce the bug anymore. The only way to reproduce it is to start over from step 1. Make sure you click away from the DAO section before shutting down Bisq. In reproducing the above, I always clicked on the Market tab before shutdown.

@chimp1984 wrote:
> This annoying bugs are likely related to the `GUIUtil.setFitToRowsForTableView` method used in most of the DAO views to layout the tableViews. There is some rendering/timing isssue and even we though it got fix with some changes in the past it seems its still not fixed. Probably a different approach to make sure the tableView is displayed with a min. height but also not using up too much space if not filled is needed...

### Expected behaviour

The transactions table should disappear when the user clicks away to a different BSQ Wallet tab.

### Actual behaviour

The transactions table stays persists in place as described in the repro steps above.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/3739
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191203/cab609dc/attachment.html>