[bisq-network/bisq] Fix resource leak caused by not cleaning up unused threads (#3734)

[Florian Reimair]

> BUNDLE_OF_ENVELOPES looks deprecated so nothing should be scheduled on the executor, right?. What is the supported backwards-compatibility here and Is there a point to even keeping this code path around?

yes, the capability "BUNDLE_OF_ENVELOPES" has been deprecated as we made it default with the forced update. So the feature is still there and active with current clients, but the capability is not required anymore.

> I tested v1.2.4 without this patch and don't see the threads increasing with simple disconnect/reconnect. Is there something I need to do to exercise the code path?

The code path only gets triggered if the throttle limits get hit (defined in https://github.com/bisq-network/bisq/blob/037f1672ddbf4d9db4f919f1332942fe96102bbb/p2p/src/main/java/bisq/network/p2p/network/Connection.java#L193)

as said above, this stuff is hard to test. After initial tests I had either version run in production for days with a profiler attached...


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3734#issuecomment-561412988
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191203/45428b04/attachment-0001.html>