[bisq-network/bisq-website] Add Schema.org JSON-LD Microdata for SEO (Homepage) (#290)

Steve Jain notifications at github.com
Wed Dec 4 04:47:59 UTC 2019


m52go requested changes on this pull request.

Sorry, one more thing. I just realized when merging #307 that post pages will have 2 conflicting JSON-LD specifications since `post` pages also use the `default.html` layout.

My suggested changes here skip adding JSON-LD markup to `default.html` when the page is for a post. This should fix the issue.

It looks to me like the changes in this PR should not conflict with the FAQ markup from #291, but let me know if you think otherwise.

> @@ -63,6 +63,54 @@
         <script defer src="/js/bootstrap.min.js"></script>
         <script defer src="/js/scripts.js"></script>
 

```suggestion

{% unless page.layout == "post" %}
```

> +            "releaseNotes": "https://github.com/bisq-network/bisq/releases/latest",
+            "screenshot": "https://bisq.network/images/bisq_screen0.png",
+            "softwareVersion": "{{ site.client_version }}",
+            "aggregateRating": {
+            "@type": "AggregateRating",
+            "ratingValue": "5",
+            "ratingCount": "5"
+          },
+          "offers": {
+            "@type": "Offer",
+            "price": "0",
+	    "priceCurrency": "BTC"
+          }
+        }
+        </script>
+

```suggestion
{% endunless %}

```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-website/pull/290#pullrequestreview-326598304
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191203/ba29c3b1/attachment.html>


More information about the bisq-github mailing list