[bisq-network/bisq] [1.2.4] Takers transactions are inconsistent with what is shown to them at take offer time (#3733)

[Christoph Atteneder]

> when testing assumed that, since it's going as two btc transactions fees are split. anyways if there was simple note or doc explaining how the split up happens in real it would help for testing.

Yes, the mining fees are split and added two these two transactions. I think the label `Taker and tx fee` is misleading if as tx fee/mining fee is added to both transactions. Possibly it would be better just to write Taker fee and leave out the tx fee/mining fee wording as I think it is common knowledge how the mining fee is used.



> [3] Observing the trade details.
> Taker mining fee = 0.000078 <-- This does not match the mining fee shown above in [1] (0.000114)

This is something I also don't understand the calculation of it.
https://github.com/bisq-network/bisq/blob/d0bed936bd55e93b7e3fba616da31ac6f9eaf10c/desktop/src/main/java/bisq/desktop/main/overlays/windows/TradeDetailsWindow.java#L220
@chimp1984 Why are we doing a multiply in the UI to calculate the mining fee for taker?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/3733#issuecomment-561729837
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191204/f9a03f6b/attachment-0001.html>