[bisq-network/bisq] Rename "Spread" tab to a more general "Details" (#3745)

Julian Knutsen notifications at github.com
Wed Dec 4 17:29:41 UTC 2019


julianknutsen commented on this pull request.

**Testing**

The english version looks good.
![verify_details](https://user-images.githubusercontent.com/8082291/70165570-fc6ad300-1677-11ea-9acb-4d8fc015fe21.JPG)

The Spanish version still has the old text which I think is to be expected. I have no experience with how the translations are done, so someone with a better understanding of the workflow can weigh in here.

![verify_details_spanish](https://user-images.githubusercontent.com/8082291/70165610-0e4c7600-1678-11ea-9833-3336f24599f1.JPG)

The fact that this was marked as a "Good First Issue" makes me think it is OK for just the english version to change, but @ripcurlx or @freimair can clear that up.

As far as your analysis on whether or not this is the "best" text. I think that this issue has been up for review for almost two months now so any sort of bikeshedding on it should have happened. The new text is definitely moving it in the right direction imo.




-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3745#pullrequestreview-327024835
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191204/fa154a59/attachment.html>


More information about the bisq-github mailing list