[bisq-network/bisq] Release v1.2.4 - v1.2.4

Thu Dec 5 18:54:19 UTC 2019

## Release notes
This release is packed with bug fixes and improvements. It improves mailbox handling when a trading peer or arbitrator/mediator is offline, shows account age for high-risk payment methods in the UI, and should improve the trade process robustness in general.

### DAO
- [Only show accepted bonded roles in bond view](https://github.com/bisq-network/bisq/pull/3676)

### UI
- Text improvements: [1](https://github.com/bisq-network/bisq/pull/3591), [2](https://github.com/bisq-network/bisq/pull/3624), [3](https://github.com/bisq-network/bisq/pull/3637), [4](https://github.com/bisq-network/bisq/pull/3643), [5](https://github.com/bisq-network/bisq/pull/3647), [6](https://github.com/bisq-network/bisq/pull/3696)
- [Fix malformed trade chat & dispute speech bubbles](https://github.com/bisq-network/bisq/pull/3680)
- [Replace arbitration link in terms and conditions](https://github.com/bisq-network/bisq/pull/3696)
- [Use correct language tags for script and regional language variants](https://github.com/bisq-network/bisq/pull/3716)
- [Add traditional Chinese](https://github.com/bisq-network/bisq/pull/3714)

### Trading
- [Re-introduce account age to payment methods with high chargeback risk](https://github.com/bisq-network/bisq/pull/3580)
- [Improve account signing security](https://github.com/bisq-network/bisq/pull/3682)
- [Fix possiblePaymentAccounts.isEmpty() bug when trying to take an offer with a MIN/MAX range](https://github.com/bisq-network/bisq/pull/3625)
- [Update trading instruction for XMR (Monero)](https://github.com/bisq-network/bisq/pull/3596)
- [Fix problem with MoneyGram account creation](https://github.com/bisq-network/bisq/pull/3600)
- [Fix bug that new payment accounts for specific payment methods couldn't be removed without restart](https://github.com/bisq-network/bisq/pull/3612)
- [Prevent taking of offers with unequal bank account types (excl. SEPA)](https://github.com/bisq-network/bisq/pull/3673)
- [Added check for empty fields for general bank accounts and MoneyBeam on creation](https://github.com/bisq-network/bisq/pull/3573)
- [Added check for empty fields in PopMoney, Uphold, Revolut and Zelle accounts on creation](https://github.com/bisq-network/bisq/pull/3575)
- [Use 2of2 multisig deposit transaction version for manual payout](https://github.com/bisq-network/bisq/pull/3694)
- [Not use 0 BTC outputs](https://github.com/bisq-network/bisq/pull/3725)
- [Fix problem of trades with mediated payout end up in failed trades](https://github.com/bisq-network/bisq/pull/3726)

### Performance
- [Fix resource leak caused by not cleaning up unused threads](https://github.com/bisq-network/bisq/pull/3734)

### Network
- Fix cases where removal of mailbox message wasn't possible: [1](https://github.com/bisq-network/bisq/pull/3584), [2](https://github.com/bisq-network/bisq/pull/3609)
- [Properly remove expire entries on disconnect](https://github.com/bisq-network/bisq/pull/3608)
- [Fix bug of unnecessary syncing of temporary proposal payloads](https://github.com/bisq-network/bisq/pull/3636)

### Installation
- [Check for special characters in installation path on Windows that prevented the app to start](https://github.com/bisq-network/bisq/pull/3642)

### Development
- [Fix failing test when there are spaces in the project path](https://github.com/bisq-network/bisq/pull/3578)
- [Upgrade Gradle wrapper to version 5.6.4](https://github.com/bisq-network/bisq/pull/3627)
- [Upgrade Gradle Shadow plugin from 4.0.2 to 5.2.0](https://github.com/bisq-network/bisq/pull/3635)
- [Upgrade JavaFX to 11.0.2](https://github.com/bisq-network/bisq/pull/3630)

### Build
- [Improve version parsing for Windows](https://github.com/bisq-network/bisq/pull/3631)

### Assets
No new assets where added.

## Verification

Url of the signing key (Christoph Atteneder): https://bisq.network/pubkey/29CDFD3B.asc
Full fingerprint: `CB36 D7D2 EBB2 E35D 9B75  500B CD5D C1C5 29CD FD3B`

Import the key:
`curl https://bisq.network/pubkey/29CDFD3B.asc | gpg --import`
GPG prints a confusion warning: "This key is not certified with a trusted signature!" - See https://serverfault.com/questions/569911/how-to-verify-an-imported-gpg-key for background information what it means.

How to verify signatures?
`gpg --digest-algo SHA256 --verify BINARY{.asc*,}`
Replace BINARY with the file you downloaded (e.g. Bisq-1.2.4.dmg)

Verify jar file inside binary:
You can verify on OSX the jar file with:
`shasum -a256 [PATH TO BISQ APP]/Bisq.app/Contents/Java/Bisq-1.2.4.jar`
The output need to match the value from the Bisq-1.2.4.jar.txt file.

## Known issues with installation 

### macOS Catalina:
> Bisq would like to receive keystrokes from any application.

Discussed in issue https://github.com/bisq-network/bisq/issues/3373, you will see a permission request in the latest macOS version that Bisq wants to receive keystrokes from any application. Unfortunately that is an issue for all Java applications that are run on Catalina right now. We are investigating already how to solve this issue and will fix in one of our next updates.

### Windows:

There is a known issue with Anti Virus software. We got several reports from users running into different problems. Either the AV software blocks Bisq or Tor, delete files in the data directory [2] or app directory [1]) or cause such a long delay at startup that Tor gets terminated and a file remains locked which can cause that Bisq cannot be started afterwards. To resolve that you need to restart Windows then the lock get released. We are working on solutions to fix those issues.

If you use Crypto currencies on your Windows system be aware that Windows is much more vulnerable to malware than Linux or OSX. Consider to use a dedicated non-Windows system when dealing with cryptocurrencies.

[1] Application directory (contains application installation files):
C:\Users\<username>\AppData\Local\Bisq

[2] Data directory (contains all Bisq data including wallet):
C:\Users\<username>\AppData\Roaming\Bisq\btc_mainnet\tor (you can delete everything except the hiddenservice directory)

### Linux:

Hint for Debian users:
If you have problems starting Bisq on Debian use: `/opt/Bisq/Bisq`

If your Linux distro does not support .deb files please follow this instruction:
```
cd ~/Downloads  
mkdir tmp  
cd tmp   
ar x ../Bisq-64bit-1.2.4.deb  
sudo tar Jxvf data.tar.xz  
sudo cp -rp opt/Bisq /opt/
```
That instruction is not tested on many different distros. If you encounter problems please report it in a Github issue so we can improve it. 

## Cleanup tool for saved trades that failed market price check

With this release we are also shipping a cleanup tool (Bisq-cleanup-trades*). It will remove corrupt trade entries added due to bug https://github.com/bisq-network/bisq/issues/2924. Install and run once, it will shut down automatically, then install version 1.2.4 or later. You can verify the binary the same way as you do with the Bisq application.

-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/releases/tag/v1.2.4
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191205/980d8afd/attachment-0001.html>