[bisq-network/bisq] ConcurrentModificationException FileManager::saveToFile (#3752)

Julian Knutsen notifications at github.com
Thu Dec 5 23:34:21 UTC 2019


I went through and audited all the users to figure out the best way to solve this in the short and long term. Here are the current users of the FileManager and the data structures they use when iterating for persistence.

**Likely Unsafe**
BallotList - PersistableList & ArrayList
PeerList - PersistableList & ArrayList
NavigationPath - ArrayList
PreferencesPayload - ArrayList/HashMap
UserPayload - ArrayList/HashSet

**Likely Safe**
AccountAgeWitnessStore - MapStoreService & ConcurrentHashMap
BlindVoteStore - MapStoreService & ConcurrentHashMap
ProposalStore - MapStoreService & ConcurrentHashMap
SignedWitnessStore - MapStoreService & ConcurrentHashMap
TempProposalStore - MapStoreService & ConcurrentHashMap
TradeStatistics2Store - MapStoreService & ConcurrentHashMap
SequenceNumberMap - ConcurrentHashMap
AddressEntryList - Clones into new ArrayList

**Unknown**
*DaoStateStore - LinkedList (only used for clone at startup?)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/3752#issuecomment-562366014
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191205/40ae91d5/attachment-0001.html>


More information about the bisq-github mailing list