[bisq-network/bisq] (6/6) Clean up technical debt in P2PDataStorage and ProtectedStorageEntry objects (#3747)

[Florian Reimair]

freimair requested changes on this pull request.



> @@ -107,7 +107,7 @@ public boolean isValidForAddOperation() {
         if (!result) {
             String res1 = this.toString();
             String res2 = "null";
-            if (mailboxStoragePayload != null && mailboxStoragePayload.getOwnerPubKey() != null)
+            if (mailboxStoragePayload.getOwnerPubKey() != null)

(applies to all removed null-checks)
you say in the commit comment that `fromProto` will throw an exception. I cannot see that. However, it seems like the protobuf implementation does supply a default value which is not null. So either way this change should be fine. Or did I miss something here?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3747#pullrequestreview-328152352
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191206/d0ed8386/attachment.html>