[bisq-network/bisq] (6/6) Clean up technical debt in P2PDataStorage and ProtectedStorageEntry objects (#3747)

Julian Knutsen notifications at github.com
Fri Dec 6 18:15:54 UTC 2019


julianknutsen commented on this pull request.



> @@ -107,7 +107,7 @@ public boolean isValidForAddOperation() {
         if (!result) {
             String res1 = this.toString();
             String res2 = "null";
-            if (mailboxStoragePayload != null && mailboxStoragePayload.getOwnerPubKey() != null)
+            if (mailboxStoragePayload.getOwnerPubKey() != null)

I could have been more clear with the distinction. Here is the relevant code for the payload itself. Since it is a submessage in proto3 it can technically be null, but the resolver handles those cases and raises an exception:

https://github.com/bisq-network/bisq/blob/76e8c5736a6c5f56cca83323c373d2f3eb3f2542/core/src/main/java/bisq/core/proto/network/CoreNetworkProtoResolver.java#L249-L278

The other non-null issues were due to the initialized value for proto3 not being null, this isn't one of those cases.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3747#discussion_r354965237
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191206/badd9edf/attachment.html>


More information about the bisq-github mailing list