[bisq-network/bisq] Add command for signing windows executables with the default code signing certificate (#3772)

[Christoph Atteneder]

Fixes #1952.

In my role as Bisq desktop maintainer and release manager I applied for a personal code signing certificate for `DI(FH) Christoph Johann Atteneder` (yes they wanted all academic titles and names included) at Sectigo (former Comodo). I applied for a code signing certificate which will expire on December 10th 2020.

*Verification steps*
To test the behavior of a signed Windows executable you'll actually need a Windows machine to do so.
For testing purpose I've created a signed version of our Windows installer for v1.2.4.
Executable: https://www.dropbox.com/s/ukrotb5neajgwwu/Bisq-1.2.4.exe?dl=0
Signature: https://www.dropbox.com/s/hasuwvch0lag7wx/Bisq-1.2.4.exe.asc?dl=0
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/3772

-- Commit Summary --

  * Add command for signing windows executables with the default code signing certificate

-- File Changes --

    M desktop/package/windows/package.bat (6)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/3772.patch
https://github.com/bisq-network/bisq/pull/3772.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3772
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191210/4e351dc2/attachment.html>