[bisq-network/bisq] Add transient tx map to DaoState to speed up getTx queries (#3773)

[Julian Knutsen]

julianknutsen commented on this pull request.



> @@ -176,6 +189,10 @@ public Message toProtoMessage() {
     }
 
     public static DaoState fromProto(protobuf.DaoState proto) {
+        Map<String, Tx> txMap = proto.getBlocksList().stream()

If I wanted to write a test and instantiate a `DaoState` I would need to duplicate logic in order to create the cache and pass it in for the behavior to be correct. I realize we don't have those tests right now, but moving towards a structure that enables testing instead of making it more complicated may get people to actually do it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3773#discussion_r356360874
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191210/80fa83b6/attachment-0001.html>