[bisq-network/bisq] Update contribution guidelines (#3762)

[Florian Reimair]

freimair commented on this pull request.



>  
+**Tools?** If you want to develop code, we expect you to know your ways around Git and Java. Then comes testing, JavaFX, Gradle, Github, ... As for non-functional skills, we love to see people knowing their ways around P2P networks, cryptography, security, privacy, ...

> I expected a list of testing frameworks or patterns after the first three words.

I intentionally left that open.
- keep the text easy to read
- if a Java dev knows testing, we have already won. Testing (imo?) is not about a certain framework, testing is a philosophy. If there is a framework unknown to you, you just learn it (although JUnit can hardly be called unknown).
- maybe some dev comes along with a special set of skills we did not know we want and need. Not being too specific leaves some room for such a dev to fit in

Thoughts?

> The non-functional skills part doesn't seem to fit with Tools.

Agreed. Didn't like that title either. "Skills"?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3762#discussion_r356507905
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191211/d39153b6/attachment.html>