[bisq-network/bisq] Backup, restore and create a new onion address via GUI (#3044)

[Devin Bileck]

To help with testing this, I have started compiling test scenarios. I have yet to execute them - I am just trying to determine the tests that are required. They may need to be refined, but should be a good starting point. Let me know if there are any additional scenarios that should be included.


1. **Scenario**: Backing up the current onion address saves hostname and private_key files
**When** selecting the option to back up the current onion address
**And** a location/filename is chosen for the *.bisq file
**Then** the *.bisq (zip) file will be saved containing the hostname and private_key files for the active onion address


2. **Scenario**: Informational prompt is shown prior to creating a new onion address
**When** selecting the option to create a new onion address
**Then** an informational prompt is shown indicating that current reputation will be lost and a restart is required


3. **Scenario**: Creating a new onion address activates a new hidden service after restarting the application
**When** selecting the option to create a new onion address
**And** restarting the application
**Then** a new hidden service using the new onion address will be active along with the old hidden service using the old onion address – can be confirmed by observing the tor/hiddenservice directory and the log output for “Tor hidden service published” messages
_// Both addresses are still in use after restarting the application since unused address are only removed at shutdown and in this case the hidden service in question is still used as the main hidden service during shutdown_
**And** The connected peers list will show...?


4. **Scenario**: Informational prompt is shown prior to restoring an onion address
**When** selecting the option to restore an onion address
**Then** an informational prompt is shown indicating that current reputation will be lost but will be restored from the backup, and a restart is required


5. **Scenario**: Restoring a previously saved onion address activates a new hidden service after restarting the application
**When** selecting the option to restore a previous onion address and choosing a previous backup file
**And** restarting the application
**Then** a new hidden service using the restored onion address will be active along with the old hidden service using the old onion address – can be confirmed by observing the tor/hiddenservice directory and the log output for “Tor hidden service published” messages
_// Both addresses are still in use after restarting the application since unused address are only removed at shutdown and in this case the hidden service in question is still used as the main hidden service during shutdown_
**And** The connected peers list will show...?


6. **Scenario**: Unused hidden services are removed after restarting the application
**Given** there are no open offers or trades
**When** selecting the option to create a new onion address
**And** restarting the application two times
_// The application must be restarted two times because the onion address (hidden service) in question cannot be used as the main hidden service during shutdown_
**Then** the old onion address (hidden service) will no longer be active and will be removed from the tor/hiddenservice directory


7. **Scenario**: Old hidden services (onion addresses) that have open offers or trades are not removed after restarting the application
**Given** there are open offers and/or trades
**When** selecting the option to create a new onion address
**And** restarting the application two times
**Then** the old onion address (hidden service) will continue to be active and remain in the tor/hiddenservice directory, along with the new one
**And** the open offers and/or trades remain active


8. **Scenario**: Hidden services for trades that have completed are removed after restarting the application
**Given** there are open offers and/or trades
**When** a new onion address has been created
**And** the application has been restarted
**And** the open offers/trades have been completed
**And** the application has been restarted
**Then** the old onion address (hidden service) will no longer be active and will be removed from the tor/hiddenservice directory


9. **Scenario**: Restoring an onion address that is already active does not create a new hidden service
**When** selecting the option to restore a previous onion address and choosing a previous backup file containing the same onion address as is already active
**And** restarting the application
**Then** the current onion address (hidden service) will remain active and no new hidden service will be created


10. **Scenario**: Creating a new onion address comes with no reputation
**Given** the active onion address has a reputation (i.e. completed several trades with Bob)
**And** selecting the option to create a new onion address
**And** restarting the application
**When** taking an offer published by Bob
**Then** it indicates you have not traded with that peer


11. **Scenario**: Restoring an onion address restores its reputation
**Given** the active onion address has a reputation (i.e. completed several trades with Bob)
**And** there are no open offers or trades
**And** the active onion address has been backed up
**And** a new onion address has been created
**And** the application has been restarted
**When** the previous onion address is restored
**And** the application is restarted
**And** an offer published by Bob has been taken
**Then** it indicates you have traded with that peer


12. **Scenario**: An open trade can complete successfully when one peer generates a new address in the middle of the trade
**Given** Alice has created an offer and Bob has taken the offer but not initiated payment
**And** Alice has generated a new address and restarted her client
**When** Bob initiates payment
**Then** Alice will receive a notification in her client of the payment initiated
**And** the trade proceeds/completes as normal


13. **Scenario**: Old hidden services (onion addresses) that have failed trades are removed after restarting the application
_Is this correct? Or is there a valid situation where a failed trade can be reopened (i.e. by the mediator/refund agent to republish a tx)?_

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3044#issuecomment-564918988
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191212/b658572a/attachment.html>