[bisq-network/bisq] Add command for signing windows executables with the default code signing certificate (#3772)
Devin Bileck
notifications at github.com
Fri Dec 13 00:40:26 UTC 2019
devinbileck approved this pull request.
ACK
I am not able to test with a signing certificate, but when attempting to run the script without the sign tool nor a signing certificate, I encounter the following error and the script still completes.
`SignTool Error: No certificates were found that met all the given criteria.`
That seems reasonable to me. That way anyone can still run the script to generate an installer without requiring a signing certificate.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3772#pullrequestreview-331610671
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191212/f3fab355/attachment.html>
More information about the bisq-github
mailing list