[bisq-network/bisq] List Denarius (D) (#3650)

Julian Knutsen notifications at github.com
Fri Dec 13 18:48:51 UTC 2019


> @ripcurlx You are seriously going to make me recommit this as one commit? You are the one whom made me submit more than one commit..........

Rebase and force push would have taken less time than this comment took to write and would have fulfilled the request made by the reviewers.

[Step 5](https://docs.bisq.network/exchange/howto/list-asset.html#step-5-create-a-well-formed-git-commit) of `how to list an asset` explicitly states the squash requirements. If you don't follow them, expect this to be rejected.

As the lead developer of Denarius, you should be familiar with the need for signed commits as well as standardizing processes to reduce waste. We do the same thing here at Bisq to minimize the work required by reviewers and maintainers for new assets. This PR has now wasted both unnecessarily.

@ripcurlx @freimair This is a great example of why we should just [close ](https://docs.bisq.network/exchange/howto/list-asset.html#pull-requests-that-do-not-conform-to-the-requirements-above-will-be-rejected) these types of PRs as `invalid` from the beginning. Projects and developers who want their asset listed should be expected to follow the very simple steps. If they can develop and maintain an actual cryptocurrency project, they can learn how to make a valid PR.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3650#issuecomment-565561799
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191213/fff104c4/attachment.html>


More information about the bisq-github mailing list