[bisq-network/bisq] Bug in handling of Failed trades between v1.2.3 & v1.2.4, user lost BTC from wallet (#3794)

Administrator notifications at github.com
Mon Dec 16 07:37:20 UTC 2019


<!--
   SUPPORT REQUESTS: This is for reporting bugs in the Bisq app.
   If you have a support request, please join #support on Bisq's
   Keybase team at https://keybase.io/team/Bisq
-->

### Description

Bisq V 1.2.3 
Trade had become stuck waiting for blockchain confirmation. A support ticket was created using ctrl+O. The mediator suspected the problem was due to the fee being too low. The support ticket was eventually closed and a payout issued. User accepted the payout from the mediator from Open Trades. The BTC appears in users wallet but the trade remained listed in Open Trades and the BTC was locked in a trade. 

Bisq V1.2.4
After upgrade upon first start of Bisq App user is prompted about an open trade (0BHgBN) being in a problem state and was prompted to move the trade to Failed Trades. User accepted the request and the trade was now moved from Open Trades to Failed Trades. The BTC that was previously locked in trade now disappeared from users wallet.

#### Version

1.2.4

### Steps to reproduce

Look at trade 0BHgBN for an example of this problem. User lost 0.157605 bitcoin from wallet.

Arbitrators payout was issued as follows:
Ticket closed on 22 Nov 2019 10:50:29
Summary:
Payout amount for BTC buyer: 0.015010 BTC
Payout amount for BTC seller: 0.157605 BTC
Summary notes:
Not published tx.
Next steps:
Open trade and accept or reject suggestion from mediator

### Expected behaviour

The Payout amount for BTC seller: 0.157605 BTC should have gone back to users wallet after the trade was moved from Open Trades to Failed trades.

### Actual behaviour

The Payout amount for BTC seller: 0.157605 BTC was lost from the users wallet. It was previously showing as Locked in Trade and vanished completely after the trade was moved to Failed trades.

### Screenshots

![0BHgBN-Failed-Trade-Screenshot_2019-12-11_14-31-36](https://user-images.githubusercontent.com/2623245/70886738-21ded180-1fd4-11ea-803b-3dbb55e086c5.png)
![0BHgBN-Fees-Screenshot_2019-12-13_06-44-35](https://user-images.githubusercontent.com/2623245/70886759-2c996680-1fd4-11ea-8744-134e743ccd63.png)


#### Device or machine

Qubes OS V 3.2.1
Dell Inspiron Laptop

#### Additional info

Bisq Logs are attached here:

[bisqLogs.zip](https://github.com/bisq-network/bisq/files/3966553/bisqLogs.zip)



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/3794
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191215/61543e0f/attachment.html>


More information about the bisq-github mailing list