[bisq-network/bisq] Remove unused method parameters (#3806)

[Steven Barclay]

Remove unused parameters from assorted methods (as found by the IDE), excluding abstract or default methods, as well as cases where the parameter is currently unused but is probably intended to be used later.

For most other such methods, either suppress the warning (where the parameter looks like it will be needed later) or actually use the parameter where it probably should have been. The latter applies to a couple of forwarded telescoping method parameters and an injected clock parameter added a few months ago to `[Signed|AccountAge]Witness.isDateInTolerance`.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/3806

-- Commit Summary --

  * Remove unused parameters from assorted methods
  * Actually use the injected Clock param of isDateInTolerance
  * Suppress warnings of unused method params which may be needed later

-- File Changes --

    M core/src/main/java/bisq/core/account/sign/SignedWitness.java (10)
    M core/src/main/java/bisq/core/account/witness/AccountAgeWitness.java (12)
    M core/src/main/java/bisq/core/btc/wallet/TradeWalletService.java (25)
    M core/src/main/java/bisq/core/dao/presentation/DaoUtil.java (5)
    M core/src/main/java/bisq/core/locale/BankUtil.java (4)
    M core/src/main/java/bisq/core/offer/CreateOfferService.java (3)
    M core/src/main/java/bisq/core/offer/OfferUtil.java (9)
    M core/src/main/java/bisq/core/user/Preferences.java (15)
    M core/src/main/java/bisq/core/util/FormattingUtils.java (4)
    M core/src/test/java/bisq/core/user/PreferencesTest.java (2)
    M desktop/src/main/java/bisq/desktop/components/PeerInfoIconSmall.java (2)
    M desktop/src/main/java/bisq/desktop/main/dao/governance/dashboard/GovernanceDashboardView.java (15)
    M desktop/src/main/java/bisq/desktop/main/dao/governance/make/MakeProposalView.java (6)
    M desktop/src/main/java/bisq/desktop/main/funds/deposit/DepositView.java (2)
    M desktop/src/main/java/bisq/desktop/main/funds/transactions/TransactionListItemFactory.java (6)
    M desktop/src/main/java/bisq/desktop/main/funds/transactions/TransactionsListItem.java (3)
    M desktop/src/main/java/bisq/desktop/main/market/offerbook/OfferBookChartView.java (1)
    M desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferViewModel.java (6)
    M desktop/src/main/java/bisq/desktop/util/FormBuilder.java (12)
    M desktop/src/test/java/bisq/desktop/maker/PreferenceMakers.java (2)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/3806.patch
https://github.com/bisq-network/bisq/pull/3806.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3806
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191218/47081ad7/attachment.html>