[bisq-network/bisq] Add shortcut to move failed trade to pending trades (#3809)
sqrrm
notifications at github.com
Thu Dec 19 13:34:38 UTC 2019
Looking at https://github.com/bisq-network/bisq/issues/3764 and https://github.com/bisq-network/bisq/issues/3794 to see how to unlock the funds and get to arbitration. This PR adds a shortcut (ctrl+y, same as moving it from pending to failed) to move back the trade from failed trades to pending trades.
## Testing
I have run this in regtest.
1. Old trades I had in failed (I don't know their history or how they got there), moved to pending and opening a dispute works. Nothing to pay out as they didn't have any locked funds.
1. Created a trade, took it to mediation, closed the popup and moved trade to failed (with ctrl+y). Moved it back to pending trades (ctrl+y). Waited until time locked tx could be broadcast and opened a dispute. Worked as a normal dispute with refund agent.
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/3809
-- Commit Summary --
* Add shortcut to move failed trade to pending trades
-- File Changes --
M core/src/main/java/bisq/core/trade/TradeManager.java (22)
M core/src/main/java/bisq/core/trade/failed/FailedTradesManager.java (11)
M core/src/main/resources/i18n/displayStrings.properties (2)
M desktop/src/main/java/bisq/desktop/main/portfolio/failedtrades/FailedTradesDataModel.java (3)
M desktop/src/main/java/bisq/desktop/main/portfolio/failedtrades/FailedTradesView.java (32)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/3809.patch
https://github.com/bisq-network/bisq/pull/3809.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3809
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191219/43fd03c3/attachment.html>
More information about the bisq-github
mailing list