[bisq-network/bisq] Add shortcut to move failed trade to pending trades (#3809)

[chimp1984]

chimp1984 requested changes on this pull request.

NACK, see comments...

I think if we allow that it must check the deposit tx, if it is null there is no reason why to open mediation. If it is another reason (e.g. we received an error from BitcoinJ that tx was invalid) we have to check for that as well to avoid that a invalid tx spread further by causing a invalid payout from mediator.

> @@ -74,4 +74,7 @@ private void applyList() {
         list.sort((o1, o2) -> o2.getTrade().getDate().compareTo(o1.getTrade().getDate()));
     }
 
+    public void unfailTrade(Trade trade) {

I would find a name like "revertFailedTradeToPending" more clear.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3809#pullrequestreview-334760283
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191219/a64a2e27/attachment.html>