[bisq-network/bisq] [WIP] Docker containers for a DAO seednode (#3095)

wiz notifications at github.com
Sat Dec 21 16:24:12 UTC 2019


NACK - With all due respect for the hard work from @mrosseel that went into this PR, and after lots of consideration between the various strategies, my opinion is that Docker is not the best tool to install and maintain a Bisq seednode. 

I reviewed your Dockerfile setup and it looks okay, but I feel that Docker adds an unnecessary level of complexity, makes it difficult to customize the configuration of the daemons, and adds a security risk from the trusted nature of using third party docker images in the codebase.

I feel that it would be better for Bisq if we focus our efforts on the new [Bisq seednode installer](https://github.com/bisq-network/bisq/tree/master/seednode#bisq-seed-node), which allows a newbie to create a Bisq seednode with one single command, doesn't introduce any new trusted third parties, and is very transparent and easy to audit. Currently it's lacking `collectd` monitoring support, but that shouldn't be hard to add considering the entire installer was written in a day with help from @sqrrm.

I spent time reviewing your PR at your request - can I ask you to do the same and try out my new installer script and tell me what you think of it compared to your Docker approach?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3095#issuecomment-568193296
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191221/27be9ce2/attachment.html>


More information about the bisq-github mailing list