[bisq-network/bisq] Use min. refund at mediated payout (#3827)

chimp1984 notifications at github.com
Mon Dec 23 18:02:28 UTC 2019


At mediation we require a min. payout to the losing party to keep
incentive for the trader to accept the mediated payout. For Refund
agent cases we do not have that restriction.

There is a change in the adjustment behaviour for custom payout. The previous adjustment at keystroken does not work anymore as when one enters 0.1 the first 0 key stroke would trigger already the min refund value. I changed the event type to focus out, so the adjustment is only done at focus out. Clicking on the background does not trigger a focus out, only if you click on a control (text field, button, toggle,...).

I also added a check to not allow that both outputs are 0 at refund agent case. That was previously possible but caused an exception in the wallet class. Not the button will stay deactivated if both are 0 BTC.

Testing:
Run test case with mediation and refund agent and toggle between the 4 predefined payout distributions as well as a custom payout. Use diff. values including 0, negative and too high to see if it auto-adjusts after focus out. Note that mediation and refund agent have differnet policy here.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/3827

-- Commit Summary --

  * Use min. refund at mediated payout

-- File Changes --

    M core/src/main/java/bisq/core/btc/wallet/Restrictions.java (9)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/DisputeSummaryWindow.java (173)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/3827.patch
https://github.com/bisq-network/bisq/pull/3827.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3827
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191223/574a3c71/attachment.html>


More information about the bisq-github mailing list