[bisq-network/bisq] Only move to failed trades if the reject msg is critical (#3830)

[chimp1984]

We got a report where a "tx already known" message caused a failed
trade but the deposit tx was valid.
To avoid such false positives we only handle reject messages which
we consider clearly critical.

Testing:
It is hard to test as more exotic reject messages are hard to generate. When the feature was implemented I tested by setting the miner fee to 0. 
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/3830

-- Commit Summary --

  * Only move to failed trades if the reject msg is critical

-- File Changes --

    M core/src/main/java/bisq/core/app/BisqSetup.java (108)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/3830.patch
https://github.com/bisq-network/bisq/pull/3830.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3830
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191224/998c9d84/attachment.html>