[bisq-network/bisq] Refactoring of and function in ValidationResult class (#3838)

[beingindot]

This function didnt have terminating short circuit 
which is important for and operator functions.

Also this function gets called multiple times since it's validation function. 
hence improving needed here.

After verifying usages, left out following two classes
1. PercentageNumberValidator - since it's using only two validation
2. PhoneNumberValidator - have variable inputs and this is only place.

<!-- 
- make yourself familiar with the CONTRIBUTING.md if you have not already (https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md)
- make sure you follow our [coding style guidelines][https://github.com/bisq-network/style/issues)
- pick a descriptive title
- provide some meaningful PR description below
- create the PR
- in case you receive a "Change request" and/or a NACK, please react within 30 days. If not, we will close your PR and it can not be up for compensation.
- After addressing the change request, __please re-request a review!__ Otherwise we might miss your PR as we tend to only look at pull requests tagged with a "review required".
-->


You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/3838

-- Commit Summary --

  * Refactoring of and function in ValidationResult class

-- File Changes --

    M core/src/main/java/bisq/core/util/validation/InputValidator.java (22)
    M desktop/src/main/java/bisq/desktop/util/validation/BsqValidator.java (18)
    M desktop/src/main/java/bisq/desktop/util/validation/BtcValidator.java (15)
    M desktop/src/main/java/bisq/desktop/util/validation/MonetaryValidator.java (9)
    M desktop/src/main/java/bisq/desktop/util/validation/SecurityDepositValidator.java (9)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/3838.patch
https://github.com/bisq-network/bisq/pull/3838.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3838
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191228/a11faced/attachment.html>