[bisq-network/bisq] Optional DAO for users (#3837)

chimp1984 notifications at github.com
Tue Dec 31 04:35:28 UTC 2019


chimp1984 requested changes on this pull request.

NACK

>  
-    public static boolean setupInitialOptionParser(String[] args) throws IOException {
+    public static boolean setupInitialOptionParser(String[] args, boolean isBisq) throws IOException {

isBisq ???? Sounds like a very non-intuitive param name

>      private final String fullName;
     private final String scriptName;
     private final String version;
 	
-	private final Preferences prefs;
+	private static Preferences prefs = Preferences.userRoot().node("Bisq");;

If you want to achieve the behaviour of first time app start, that is done in a different style in many placed. I don't htink its a good ide to introduce this new style and the context of node is weird to me.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3837#pullrequestreview-337295273
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20191230/838dbae6/attachment.html>


More information about the bisq-github mailing list