[bisq-network/bisq] Allow tor to be used with regtest (#2346)

Manfred Karrer notifications at github.com
Sun Feb 3 02:13:34 UTC 2019

ManfredKarrer requested changes on this pull request.

> @@ -236,7 +236,6 @@ protected void onSetupCompleted() {
             if (regTestHost == RegTestHost.LOCALHOST) {
             } else if (regTestHost == RegTestHost.REMOTE_HOST) {
-                walletConfig.setMinBroadcastConnections(1);

Is that correct to remove that line?

>                  || bisqEnvironment.isBitcoinLocalhostNodeRunning())
+                && bisqEnvironment.getProperty(BtcOptionKeys.USE_TOR_FOR_BTC).isEmpty())

Maybe better to check against a boolean as USE_TOR_FOR_BTC can be set to false. A default values should be set anyway so an empty property should be not be the case if the property setup is done correctly.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190202/514efccb/attachment.html>

More information about the bisq-github mailing list