[bisq-network/bisq] Dao avoid bsq burn (#2242)
sqrrm
notifications at github.com
Sun Feb 3 15:19:23 UTC 2019
sqrrm commented on this pull request.
> @@ -248,10 +248,15 @@ private void processIssuance(int blockHeight, TempTx tempTx, long bsqFee) {
log.warn("It can be that we have a opReturn which is correct from its structure but the whole tx " +
"in not valid as the issuanceCandidate in not there. " +
"As the BSQ fee is set it must be either a buggy tx or an manually crafted invalid tx.");
- tempTx.setTxType(TxType.INVALID);
+ // Even though the request part if invalid the BSQ transfer and change output should still be valid
+ // as long as the BSQ change <= BSQ inputs.
+ tempTx.setTxType(TxType.UNDEFINED_TX_TYPE);
If we add another type we can, this was an attempt to avoid adding more txTypes.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2242#discussion_r253306210
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190203/345e5e2d/attachment.html>
More information about the bisq-github
mailing list