[bisq-network/bisq] Dao: Add handler for republishing all dao governance data, improve vote result handling (#2363)

sqrrm notifications at github.com
Sun Feb 3 19:26:52 UTC 2019


sqrrm approved this pull request.

utACK

The comments on log level stand but it's just refactoring so can be tended to in another PR

> @@ -51,4 +76,39 @@ public void start() {
     public void sendRepublishRequest() {
         republishGovernanceDataHandler.sendRepublishRequest();
     }
+
+    public void reRepublishAllGovernanceData() {
+        ObservableList<ProposalPayload> proposalPayloads = proposalService.getProposalPayloads();
+        proposalPayloads.forEach(proposalPayload -> {
+            // We want a random delay between 0.1 and 30 sec. depending on the number of items
+            int delay = Math.max(100, Math.min(30_000, new Random().nextInt(proposalPayloads.size() * 500)));
+            UserThread.runAfter(() -> {
+                boolean success = p2PService.addPersistableNetworkPayload(proposalPayload, true);
+                String txId = proposalPayload.getProposal().getTxId();
+                if (success) {
+                    log.warn("We received a RepublishGovernanceDataRequest and re-published a proposalPayload to " +

Maybe this shouldn't be warning level log

> +                } else {
+                    log.error("Adding of proposalPayload to P2P network failed. proposalTxId={}", txId);
+                }
+            }, delay, TimeUnit.MILLISECONDS);
+        });
+
+        ObservableList<BlindVotePayload> blindVotePayloads = blindVoteListService.getBlindVotePayloads();
+        blindVotePayloads
+                .forEach(blindVotePayload -> {
+                    // We want a random delay between 0.1 and 30 sec. depending on the number of items
+                    int delay = Math.max(100, Math.min(30_000, new Random().nextInt(blindVotePayloads.size() * 500)));
+                    UserThread.runAfter(() -> {
+                        boolean success = p2PService.addPersistableNetworkPayload(blindVotePayload, true);
+                        String txId = blindVotePayload.getBlindVote().getTxId();
+                        if (success) {
+                            log.warn("We received a RepublishGovernanceDataRequest and re-published a blindVotePayload to " +

Same here, I don't think warning level is right

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2363#pullrequestreview-199401103
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190203/fbdf056b/attachment.html>


More information about the bisq-github mailing list