[bisq-network/bisq] Dao avoid bsq burn (#2242)

sqrrm notifications at github.com
Sun Feb 3 21:05:35 UTC 2019

sqrrm commented on this pull request.

> @@ -248,10 +248,15 @@ private void processIssuance(int blockHeight, TempTx tempTx, long bsqFee) {
                 log.warn("It can be that we have a opReturn which is correct from its structure but the whole tx " +
                         "in not valid as the issuanceCandidate in not there. " +
                         "As the BSQ fee is set it must be either a buggy tx or an manually crafted invalid tx.");
-                tempTx.setTxType(TxType.INVALID);
+                // Even though the request part if invalid the BSQ transfer and change output should still be valid
+                // as long as the BSQ change <= BSQ inputs.
+                tempTx.setTxType(TxType.UNDEFINED_TX_TYPE);

Yeah, let's do that to show it's parsed and something is not right but it's still a valid BSQ tx in some way.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190203/b53f62dc/attachment.html>

More information about the bisq-github mailing list