[bisq-network/bisq] Allow tor to be used with regtest (#2346)

Devin Bileck notifications at github.com
Mon Feb 4 07:07:42 UTC 2019

devinbileck commented on this pull request.

>                  || bisqEnvironment.isBitcoinLocalhostNodeRunning())
+                && bisqEnvironment.getProperty(BtcOptionKeys.USE_TOR_FOR_BTC).isEmpty())

After reviewing the code again, my initial implementation appears to be technically correct and attempts to determine if the USE_TOR_FOR_BTC parameter was explicitly provided or not by checking whether the property is empty (which it will be empty if not provided). And if it is provided, do not override it to false and instead use whatever value was provided. It handles each scenario where (1) the parameter is not provided, (2) provided and set to false, and (3) provided and set to true. I did not change the implementation/type of the USE_TOR_FOR_BTC as a string parameter to boolean in order to keep it consistent with other similar parameters. If that needs to change, that can be done separately. The only thing I identified was that I should have instead used the useTorFlagFromOptions parameter rather than bisqEnvironment.getProperty. I will commit a fix for that.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190203/906df492/attachment.html>

More information about the bisq-github mailing list