[bisq-network/bisq] Initial commit of Snap package (#2378)
Christoph Atteneder
notifications at github.com
Wed Feb 6 16:26:09 UTC 2019
ripcurlx requested changes on this pull request.
NACK - see my comments below. Unfortunately I don't have time to evaluate if we want to "offically" support Snap packages. @devinbileck do you have time to look into this if we want to add this kind of support? Thanks!
> +icon: icon.png
+
+apps:
+ bisq-desktop:
+ command: desktop-launch "$SNAP/opt/bisq/bin/bisq-desktop"
+ plugs:
+ - network
+ - network-bind
+ - desktop
+ - desktop-legacy
+ - x11
+ - wayland
+ - home
+ desktop: usr/share/applications/bisq.desktop
+ environment:
+ JAVA_HOME: "$SNAP/usr/lib/jvm/java-11-openjdk-amd64"
Bisq should be built with Java 10. Java 11 isn't officially supported yet.
> +parts:
+ bisq:
+ plugin: gradle
+ override-build: |
+ ./gradlew build
+
+ # Install executable.
+ install -d "${SNAPCRAFT_PART_INSTALL}/opt/bisq"
+ cp -r desktop/build/app/* "${SNAPCRAFT_PART_INSTALL}/opt/bisq"
+
+ # Install desktop launcher icon
+ install -Dm644 desktop/package/linux/icon.png "${SNAPCRAFT_PART_INSTALL}/usr/share/pixmaps/bisq.png"
+
+ source: https://github.com/bisq-network/bisq-desktop.git
+ source-tag: v0.9.3
+ build-packages: [openjdk-11-jdk]
Bisq should be built with Java 10. Java 11 isn't officially supported yet.
> + bisq:
+ plugin: gradle
+ override-build: |
+ ./gradlew build
+
+ # Install executable.
+ install -d "${SNAPCRAFT_PART_INSTALL}/opt/bisq"
+ cp -r desktop/build/app/* "${SNAPCRAFT_PART_INSTALL}/opt/bisq"
+
+ # Install desktop launcher icon
+ install -Dm644 desktop/package/linux/icon.png "${SNAPCRAFT_PART_INSTALL}/usr/share/pixmaps/bisq.png"
+
+ source: https://github.com/bisq-network/bisq-desktop.git
+ source-tag: v0.9.3
+ build-packages: [openjdk-11-jdk]
+ stage-packages: [openjdk-11-jre]
Bisq should be built with Java 10. Java 11 isn't officially supported yet.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2378#pullrequestreview-200669786
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190206/e80e4e86/attachment-0001.html>
More information about the bisq-github
mailing list