[bisq-network/bisq] List CloakCoin (CLOAK) (#2326)
Bernard Labno
notifications at github.com
Thu Feb 7 07:54:29 UTC 2019
blabno requested changes on this pull request.
NACK per comments
> + public static class CloakCoinAddressValidator extends Base58BitcoinAddressValidator {
+
+ public CloakCoinAddressValidator() {
+ super(/*new CloakCoinParams()*/);
+ }
+
+ @Override
+ public AddressValidationResult validate(String address) {
+ if (!address.matches("^[B|C][a-km-zA-HJ-NP-Z1-9]{33}$") && !address.matches("^smY[a-km-zA-HJ-NP-Z1-9]{99}$"))
+ return AddressValidationResult.invalidStructure();
+
+ return AddressValidationResult.validAddress();
+ }
+ }
+
+/* public static class CloakCoinParams extends NetworkParametersAdapter
Remove this rubish.
> +
+package bisq.asset.coins;
+
+import bisq.asset.AddressValidationResult;
+import bisq.asset.Base58BitcoinAddressValidator;
+import bisq.asset.Coin;
+import bisq.asset.NetworkParametersAdapter;
+
+public class CloakCoin extends Coin {
+ public CloakCoin() {
+ super("CloakCoin", "CLOAK", new CloakCoinAddressValidator());
+ }
+
+ public static class CloakCoinAddressValidator extends Base58BitcoinAddressValidator {
+
+ public CloakCoinAddressValidator() {
No need for such a constructor.
> +import bisq.asset.NetworkParametersAdapter;
+
+public class CloakCoin extends Coin {
+ public CloakCoin() {
+ super("CloakCoin", "CLOAK", new CloakCoinAddressValidator());
+ }
+
+ public static class CloakCoinAddressValidator extends Base58BitcoinAddressValidator {
+
+ public CloakCoinAddressValidator() {
+ super(/*new CloakCoinParams()*/);
+ }
+
+ @Override
+ public AddressValidationResult validate(String address) {
+ if (!address.matches("^[B|C][a-km-zA-HJ-NP-Z1-9]{33}$") && !address.matches("^smY[a-km-zA-HJ-NP-Z1-9]{99}$"))
This is pure regex validation and does not use anything from super class, so just use `RegexAddressValidator` instead of creating your own validator.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2326#pullrequestreview-200953052
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190206/9ab1c6cf/attachment-0001.html>
More information about the bisq-github
mailing list