[bisq-network/bisq] Improve handling when unable to connect to tor (#2399)

Devin Bileck notifications at github.com
Fri Feb 8 22:22:53 UTC 2019

Issue: If an IOException is raised when attempting to create
tor and the hidden service, the application will just quit without
any indication to the user. One particular scenario where this occurs
is mentioned in https://github.com/bisq-network/bisq/issues/2398.

Cause: There is an explicit statement to exit the application when an
IOException is raised.

Fix: Rather than just exit the application, show an error message
and inform the user what went wrong.
You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * Improve handling when unable to connect to tor

-- File Changes --

    M core/src/main/java/bisq/core/app/BisqSetup.java (9)
    M core/src/main/java/bisq/core/app/P2PNetworkSetup.java (5)
    M core/src/main/java/bisq/core/app/WalletAppSetup.java (5)
    M desktop/src/main/java/bisq/desktop/main/MainView.java (27)
    M desktop/src/main/java/bisq/desktop/main/MainViewModel.java (4)
    M p2p/src/main/java/bisq/network/p2p/network/SetupListener.java (1)
    M p2p/src/main/java/bisq/network/p2p/network/TorNetworkNode.java (13)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190208/f004dea2/attachment.html>

More information about the bisq-github mailing list