[bisq-network/bisq] Wait until proposal is published before resetting the form (#2384)

sqrrm notifications at github.com
Sun Feb 10 10:39:08 UTC 2019


sqrrm commented on this pull request.

See comment on animation on error.  Apart from that it looks good.

>                  },
-                errorMessage -> new Popup<>().warning(errorMessage).show());
+                errorMessage -> {
+                    new Popup<>().warning(errorMessage).show();
+                    makeProposalButton.setDisable(false);

By not disabling the busyAnimation/button here it will keep spinning after an error was reported, I don't think that's correct.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2384#pullrequestreview-201897374
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190210/c1db7a97/attachment.html>


More information about the bisq-github mailing list