[bisq-network/bisq] Add indication that BSQ transactions are not up to date (#2388)

sqrrm notifications at github.com
Sun Feb 10 11:16:43 UTC 2019


sqrrm approved this pull request.

ACK

I have tested and it works, but I still think it would be better with a separate service for the sync handling to not pollute the setup class.

>  /**
  * High level entry point for Dao domain.
  * We initialize all main service classes here to be sure they are started.
  */
-public class DaoSetup {
+public class DaoSetup implements DaoStateListener {

I think it would be better to make a separate BSQSyncService or something like that, it feels wrong to add this to the DaoSetup.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2388#pullrequestreview-201898622
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190210/9b7e7610/attachment.html>


More information about the bisq-github mailing list