[bisq-network/bisq] Add indication that BSQ transactions are not up to date (#2388)

Christoph Atteneder notifications at github.com
Mon Feb 11 07:49:50 UTC 2019


ripcurlx commented on this pull request.



>  /**
  * High level entry point for Dao domain.
  * We initialize all main service classes here to be sure they are started.
  */
-public class DaoSetup {
+public class DaoSetup implements DaoStateListener {

Yes, I also wasn't quite happy to put it in this place, I just though to make it consistent how it is handled with the btcInfo WalletSetup right now:
https://github.com/bisq-network/bisq/blob/8cdc7599031a159b5c311904299136ba14b8a0a0/core/src/main/java/bisq/core/app/BisqSetup.java#L341-L348
https://github.com/bisq-network/bisq/blob/8cdc7599031a159b5c311904299136ba14b8a0a0/core/src/main/java/bisq/core/app/WalletAppSetup.java#L68

How do we differentiation between a Facade and a Service atm in Bisq?
I'll have a look to find a better place for this presentation logic. I might change the implementation of the btcInfo/btcSyncProgress on the way as well.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2388#discussion_r255400785
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190210/df03b468/attachment-0001.html>


More information about the bisq-github mailing list