[bisq-network/bisq] Show BSQ trading fee more explicitly when funding your offer (#2379)

Christoph Atteneder notifications at github.com
Mon Feb 11 08:57:16 UTC 2019


ripcurlx commented on this pull request.



> @@ -373,6 +373,7 @@ createOffer.fundsBox.networkFee=Mining fee
 createOffer.fundsBox.placeOfferSpinnerInfo=Offer publishing is in progress ...
 createOffer.fundsBox.paymentLabel=Bisq trade with ID {0}
 createOffer.fundsBox.fundsStructure=({0} security deposit, {1} trade fee, {2} mining fee)
+createOffer.fundsBox.fundsStructure.BSQ=({0} security deposit, {1} mining fee) + {2} trade fee

The reason why I did it like that is, that it would otherwise look like as if it is part of the total btc funds needed.
<img width="981" alt="bildschirmfoto 2019-02-11 um 09 54 54" src="https://user-images.githubusercontent.com/170962/52553221-1edae980-2de3-11e9-8583-1d36cbff23cf.png">
So I implemented it as follows:
<img width="984" alt="bildschirmfoto 2019-02-11 um 09 56 30" src="https://user-images.githubusercontent.com/170962/52553289-534ea580-2de3-11e9-9ced-09bb2755c690.png">



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2379#discussion_r255415891
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190211/ceb71c78/attachment-0001.html>


More information about the bisq-github mailing list