[bisq-network/bisq] Show BSQ trading fee more explicitly when funding your offer (#2379)

Christoph Atteneder notifications at github.com
Mon Feb 11 14:17:32 UTC 2019

ripcurlx commented on this pull request.

> @@ -373,6 +373,7 @@ createOffer.fundsBox.networkFee=Mining fee
 createOffer.fundsBox.placeOfferSpinnerInfo=Offer publishing is in progress ...
 createOffer.fundsBox.paymentLabel=Bisq trade with ID {0}
 createOffer.fundsBox.fundsStructure=({0} security deposit, {1} trade fee, {2} mining fee)
+createOffer.fundsBox.fundsStructure.BSQ=({0} security deposit, {1} mining fee) + {2} trade fee

On first sight yes, but we have this order on a couple of places and it makes sense from my point of view to have it as it is right now:
<img width="604" alt="bildschirmfoto 2019-02-11 um 15 12 05" src="https://user-images.githubusercontent.com/170962/52568611-8a3ab080-2e0f-11e9-827d-b27bfbb2ad6d.png">

<img width="986" alt="bildschirmfoto 2019-02-11 um 15 11 08" src="https://user-images.githubusercontent.com/170962/52568601-83ac3900-2e0f-11e9-9948-a346eaed6086.png">

<img width="1138" alt="bildschirmfoto 2019-02-11 um 15 14 44" src="https://user-images.githubusercontent.com/170962/52568700-ce2db580-2e0f-11e9-8181-3e9bbc68de26.png">

The only problem is to mix it in the total funds field with the BSQ value.
I personally would  go with this little inconsistency and have the order in this field different between BSQ and BTC trading fees.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190211/19847c2f/attachment.html>

More information about the bisq-github mailing list