[bisq-network/bisq] Update view on activation with block at current chain height (#2409)

Manfred Karrer notifications at github.com
Tue Feb 12 14:52:52 UTC 2019


ManfredKarrer approved this pull request.

Beside the @Nullable/Optional issue utACK

> @@ -484,6 +485,15 @@ public int getChainHeight() {
         return daoStateService.getChainHeight();
     }
 
+    public Block getBlockAtChainHeight() {
+        return getBlockAtHeight(getChainHeight());
+    }
+
+    public Block getBlockAtHeight(int chainHeight) {

Please add @Nullable

> @@ -484,6 +485,15 @@ public int getChainHeight() {
         return daoStateService.getChainHeight();
     }
 
+    public Block getBlockAtChainHeight() {
+        return getBlockAtHeight(getChainHeight());
+    }
+
+    public Block getBlockAtHeight(int chainHeight) {

Or stick with Optional...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2409#pullrequestreview-202651286
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190212/8b8852c8/attachment.html>


More information about the bisq-github mailing list