[bisq-network/bisq] [WIP] Feature dark mode (#2414)
notifications at github.com
Thu Feb 14 18:25:50 UTC 2019
> > Looks like the compass build doesn't work correctly - I've added in the generated CSS files which is a good idea anyhow. The SASS build should probably not be on the build critical path anyway.
> I'm not sure if it is a good idea to put precompiled files in the project, as this might cause confusion if someone changes the css code and later the sass files are processed and overwrite the changes. I think it should work that if someone runs `gradle build` also the required css files should be generated. The same goes with Intellij. If I change code in the SASS file and run the app I expect the changes to be reflected in the app without doing manual processing of the SASS files.
Agreed, that would be the way most devs expect it to work. (Though it can be argued that the SASS files are not likely to change very often, and the Compass build step does add a few seconds to the build. Maybe a separate build step and a "this file is generated from..." warning at the top of the CSS files is a decent compromise?)
> Is there a reason why it is not working like that?
I couldn't replicate the issue in a fresh environment, am getting the `com.github.anbuck.compass` gradle plugin to load correctly. Could you look out for this as part of your review next week?
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the bisq-github