[bisq-network/bisq] Increase trade limit. Make trade limit a DAO parameter (#2413)

Manfred Karrer notifications at github.com
Thu Feb 14 19:48:21 UTC 2019

ManfredKarrer commented on this pull request.

>              return Coin.parseCoin("4");
+        // We use the class field maxTradeLimit only for mapping the risk factor.
+        long riskFactor;
+        if (maxTradeLimit == DEFAULT_TRADE_LIMIT_VERY_LOW_RISK.value)

Ups, the PaymentMethod constructor was called from the Offer, that caused the issue. I will remove that. the fields are all final now so it has to be guaranteed anyway that the data from the offer payload matches the default values in the code. The difference is that we supported with that that an offer could have different limits and durations as the actual code base (in case a new version has changed those). I think that is not much an issue as we must not change those default values anyway and if so they only may increase otherwise we could render an offer invalid (if amount becomes lower as limit). The maker gets a "promis" when he creates the offer to those data (most relevant is trade duration here) so we have to consider that if we would decide to change default values. So far there have been no need to change those but for altcoins it might become interesting to support very short durations (live trades) in some future releases. But lets discuss once we get there, the duration should be probably refactored then so that there is only the default value in and the real value will be delivered by some service, or we add a new payment methods reflecting that new properties (easier probably). 

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190214/8c727174/attachment.html>

More information about the bisq-github mailing list