[bisq-network/bisq] Implement correct and complete Monero and Cryptonote address validator (#2422)
xiphon
notifications at github.com
Fri Feb 15 01:35:02 UTC 2019
Fixes https://github.com/bisq-network/bisq/issues/1652
Implements address decoding, checksum validation, prefix matching and public keys length checks.
The code is consistent with Monero codebase.
Supports all the other Cryptonote coins as well.
PS:
Skips `Cash2` checksum validation (the coin uses `BLAKE2b` instead of `Keccak1600`), but there are still plenty of other checks out there.
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/2422
-- Commit Summary --
* Implement correct and complete Monero and Cryptonote address validator
-- File Changes --
M assets/src/main/java/bisq/asset/CryptonoteAddressValidator.java (324)
M assets/src/main/java/bisq/asset/coins/Aeon.java (2)
M assets/src/main/java/bisq/asset/coins/Blur.java (2)
M assets/src/main/java/bisq/asset/coins/Cash2.java (2)
M assets/src/main/java/bisq/asset/coins/FourtyTwo.java (2)
M assets/src/main/java/bisq/asset/coins/Mask.java (2)
M assets/src/main/java/bisq/asset/coins/Monero.java (2)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/2422.patch
https://github.com/bisq-network/bisq/pull/2422.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2422
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190214/b256a7c9/attachment.html>
More information about the bisq-github
mailing list