[bisq-network/bisq] List DSTRA (DST) (#2385)

krestien notifications at github.com
Mon Feb 18 09:59:31 UTC 2019

krestien commented on this pull request.

> +
+public class DSTRATest extends AbstractAssetTest {
+    public DSTRATest() {
+        super(new DSTRA());
+    }
+    @Test
+    public void testValidAddresses() {
+        assertValidAddress("DGiwGS8n3tJZuKxUdWF6MyTYvv6xgDcyd7");
+        assertValidAddress("DQcAKx5bFoeRwAEHE4EHQykyq8u2M1pwFa");
+    }
+    @Test
+    public void testInvalidAddresses() {
+        assertInvalidAddress("DGiwGS8n3tJZuKxUdWF6MyTYvv6xgDcyd77");

Hi @blabno and thank you for checking my PR! 
After review I simply can't find the spot where I violated Bisq code style. I took a look at several examples (PIVXTest, ZcashTest, etc.) and it seems to me like my file is exactly looking the same.
Maybe you can guide me to what's wrong with my Test class. Only style reference for bisq I found is https://github.com/bisq-network/style and it doesn't contain anything regarding code style as far as I could see as it's pretty new.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190218/53362b52/attachment-0001.html>

More information about the bisq-github mailing list