[bisq-network/bisq] Monitor release: Settled (#2432)

Manfred Karrer notifications at github.com
Tue Feb 19 03:45:52 UTC 2019

ManfredKarrer requested changes on this pull request.

> if(Capabilities.getSupportedCapabilities().isEmpty())
                Arrays.stream(Capabilities.Capability.values()).forEach(capability -> Capabilities.addCapability(capability.ordinal()));

We should not add all Capabilities automatically. For instance as you dont run it as full DAO node you will not handle BSQ Block requests.

> P2PSeedNodeSnapshot.run.hosts=3f3cu2yw7u457ztq.onion:8000, 723ljisnynbtdohi.onion:8000, fl3mmribyxgrv63c.onion:8000
PriceNodeStats.run.hosts=http://5bmpx76qllutpcyp.onion, http://xc3nh4juf2hshy7e.onion, http://44mgyoe2b6oqiytt.onion, http://62nvujg5iou3vu3i.onion, http://ceaanhbvluug4we6.onion

Maybe its better to use the nodes from the code, so if it gets updated there is not need to update config files? Or maybe to use default code based nodes and if config is set it will override the default nodes?

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190218/e8ea0035/attachment.html>

More information about the bisq-github mailing list