[bisq-network/bisq] Refactor capabilities (#2469)

[Florian Reimair]

Got rid of the Capability ordinals being used all over the place - a first and major step towards a cleaner, more readable Bisq code base where Bugs have less places to hide. (Done in my intention to clean up the p2p part)

Doing that I even managed to remove some 60 loc: some stats using `github.com/AlDanial/cloc v 1.80`

_|files|blank|comment|code
:-------|-------:|-------:|-------:|-------:
same|0|0|971|3544
 modified|29|0|6|148
 added|1|18|36|64
 removed|0|11|3|125


# Note
this is a fairly big change where functionality should remain the same. However, this needs thorough testing.
My suggestion is that every reviewer of this PR should have a testing session with me where we do the basic things such as a simple trade so major bugs are discovered before merging.
In-depth testing is done anyhow before the next release...

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/2469

-- Commit Summary --

  * Get rid of Capability ordinals
  * Removed duplicate and superfluous code
  * Make Monitor aware of refactoring

-- File Changes --

    M common/src/main/java/bisq/common/app/Capabilities.java (114)
    A common/src/main/java/bisq/common/app/Capability.java (35)
    M common/src/test/java/bisq/common/app/CapabilitiesTest.java (54)
    M core/src/main/java/bisq/core/dao/governance/blindvote/network/RepublishGovernanceDataHandler.java (11)
    M core/src/main/java/bisq/core/dao/governance/blindvote/network/messages/RepublishGovernanceDataRequest.java (11)
    M core/src/main/java/bisq/core/dao/governance/blindvote/storage/BlindVotePayload.java (10)
    M core/src/main/java/bisq/core/dao/governance/proposal/storage/appendonly/ProposalPayload.java (11)
    M core/src/main/java/bisq/core/dao/governance/proposal/storage/temp/TempProposalPayload.java (10)
    M core/src/main/java/bisq/core/dao/node/messages/GetBlocksRequest.java (11)
    M core/src/main/java/bisq/core/dao/node/messages/NewBlockBroadcastMessage.java (11)
    M core/src/main/java/bisq/core/offer/messages/OfferAvailabilityRequest.java (11)
    M core/src/main/java/bisq/core/offer/messages/OfferAvailabilityResponse.java (11)
    M core/src/main/java/bisq/core/payment/AccountAgeWitness.java (10)
    M core/src/main/java/bisq/core/setup/CoreNetworkCapabilities.java (21)
    M core/src/main/java/bisq/core/trade/statistics/TradeStatistics2.java (10)
    M monitor/src/main/java/bisq/monitor/metric/P2PNetworkLoad.java (9)
    M p2p/src/main/java/bisq/network/p2p/AckMessage.java (10)
    M p2p/src/main/java/bisq/network/p2p/P2PService.java (9)
    M p2p/src/main/java/bisq/network/p2p/SupportedCapabilitiesMessage.java (4)
    M p2p/src/main/java/bisq/network/p2p/network/Connection.java (61)
    M p2p/src/main/java/bisq/network/p2p/network/SupportedCapabilitiesListener.java (4)
    M p2p/src/main/java/bisq/network/p2p/peers/PeerManager.java (18)
    M p2p/src/main/java/bisq/network/p2p/peers/getdata/GetDataRequestHandler.java (27)
    M p2p/src/main/java/bisq/network/p2p/peers/getdata/messages/GetDataResponse.java (11)
    M p2p/src/main/java/bisq/network/p2p/peers/getdata/messages/PreliminaryGetDataRequest.java (11)
    M p2p/src/main/java/bisq/network/p2p/peers/peerexchange/Peer.java (29)
    M p2p/src/main/java/bisq/network/p2p/peers/peerexchange/messages/GetPeersRequest.java (11)
    M p2p/src/main/java/bisq/network/p2p/peers/peerexchange/messages/GetPeersResponse.java (13)
    M p2p/src/main/java/bisq/network/p2p/storage/payload/CapabilityRequiringPayload.java (5)
    M seednode/src/main/java/bisq/seednode/SeedNodeMain.java (8)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/2469.patch
https://github.com/bisq-network/bisq/pull/2469.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2469
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190226/31c86b4d/attachment-0001.html>